Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
@sbillinge, it's ready for review. |
sbillinge
reviewed
Feb 13, 2026
Contributor
sbillinge
left a comment
sbillinge
left a comment
There was a problem hiding this comment.
please see comment.
I will merge this so you can keep working more easily, but please can you make the fix I requested?
| # ), | ||
| # ) | ||
| sts.run(mode="stream") | ||
| if __name__ == "__main__": |
Contributor
There was a problem hiding this comment.
we normally define a main and then we just run
if __name__ == "__main__":
main()
This is cleaner than what is done here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR address?
Closes #33
This is because
matplotlibinstead ofmatplotlib-baseis used.Also, errors were found when runing example scripts in windows. It turns out the main script must run under
for
multiprocessingto work normaly in windows.What should the reviewer(s) do?
Please check the modifications.